-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log watch entry points #719
Add log watch entry points #719
Conversation
/cc stbenjam |
/cc @kashifest @maelk /test-integration |
b5597ad
to
9b4051a
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akiselev1, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test-integration |
/approve Oops, I meant to give @maelk and @kashifest a chance to review this. |
I am not sure if we would want to add the container here also https://github.com/metal3-io/baremetal-operator/blob/master/tools/run_local_ironic.sh since in case of test integration we deploy the ironic locally. When this is decided, I would also like to run centos tests to verify ironic deployment. |
+1 to adding it to the run_local_ironic.sh script. Otherwise lgtm |
btw, if it is added to run_local_ironic.sh, the cleanup scripts in metal3-dev-env will need to be updated too. |
@maelk Can you share the link to these cleanup scripts? |
@kashifest What is the command to run centos tests? |
https://github.com/metal3-io/metal3-dev-env/blob/master/lib/common.sh#L426 The command would be / test-centos-integration |
9b4051a
to
9568f9d
Compare
/test-centos-integration |
/test-integration |
1 similar comment
/test-integration |
/test-integration |
I'm not 100% sure if that's the reason for the below issue on the failed CI
but it seems that runlogwatch.sh is not executable (no +x permission).
|
@fmuyassarov Thank you! I think I know what happened. I forgot to set +x permission in the original PR, and created a new one: metal3-io/ironic-image#221 to fix that. You can see correct +x permission if you do |
Make sense. Last built in the quay for the Ironic image was on Noveber 12th, 13:02 (I'm not sure though if it shows my local time) and from the git log your fix was merged on November 12th, at 14:02 (it is my local time). Maybe there is some time mismatch on my browser. I would assume quay was triggered, but then ...why didn't it take changes...
But hopefully Doug or Maël have some ideas. Maybe there is a way we can trigger the build for the quay? |
Looks like we hit an iceberg: You have reached your pull rate limit. |
/test-integration |
Something went wrong in the CI infra I believe. |
Hm... Ironic image did get updated in Quay. But CI results are empty. Do we have any doc on metal3 CI architecture? Let me know if I can help in any way. |
it seems like the opensuse pages are down. The CI failed to download the release keys. |
Opensuse is back. |
/cc @fmuyassarov @maelk @kashifest - CI finally passed. May I have lgtm from one of you? |
/lgtm |
/test-v1a3-centos-integration |
Adding ironic and ironic-inspector log watch entry points per this design proposal: https://github.com/metal3-io/metal3-docs/blob/master/design/ironic-debuggability-improvement.md