Add new entry point script to dump ramdisk host provisioning logs #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
dtantsur
requested changes
Nov 9, 2020
elfosardo
requested changes
Nov 9, 2020
akiselev1
force-pushed
the
ironic-provisioning-log-watch
branch
from
cbee3ff
to
55de950
Compare
akiselev1
force-pushed
the
ironic-provisioning-log-watch
branch
2 times, most recently
from
e365dcd
to
08ca5ee
Compare
akiselev1
changed the title
metal3-io-bot
added
the
do-not-merge/work-in-progress
akiselev1
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
akiselev1
force-pushed
the
ironic-provisioning-log-watch
branch
from
08ca5ee
to
2005bff
Compare
|
@dtantsur , @elfosardo - PTAL |
akiselev1
force-pushed
the
ironic-provisioning-log-watch
branch
from
2005bff
to
33cca8e
Compare
dtantsur
reviewed
Nov 11, 2020
akiselev1
force-pushed
the
ironic-provisioning-log-watch
branch
from
33cca8e
to
02f8d61
Compare
akiselev1
force-pushed
the
ironic-provisioning-log-watch
branch
from
02f8d61
to
d14ee53
Compare
|
OK, let's take this as a first approach and see how much performance is actually affected. We can iterate if we need to improve it. /test-integration |
elfosardo
approved these changes
Nov 12, 2020
|
mmm I can't approve :/ |
dtantsur
approved these changes
Nov 12, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akiselev1, dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
dtantsur
pushed a commit
to dtantsur/ironic-image
that referenced
this pull request
Oct 4, 2021
Remove unsafe default for IRONIC_AGENT_IMAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in series of PRs implementing this design proposal: https://github.com/metal3-io/metal3-docs/blob/master/design/ironic-debuggability-improvement.md