Fix the issue that the OS is not a Stream version #259
Conversation
|
/assign @dtantsur |
|
/test-integration |
|
/approve |
|
/test-integration |
|
/test-integration Maybe we should consider switching to Stream, but right now it's blocking the image builds. |
metal3-io-bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo, namnx228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test-integration |
metal3-io-bot
added
size/XS
|
/test-integration |
|
/test-centos-integration |
| @@ -17,6 +17,7 @@ if [ ! -f "$MARIADB_CERT_FILE" ] && [ -f "$MARIADB_KEY_FILE" ] ; then | |||
| fi | |||
|
|
|||
| ln -sf /proc/self/fd/1 /var/log/mariadb/mariadb.log | |||
| rm -f /usr/bin/mysqld_safe_helper # Avoid this script being used which results in a permission denied error. | |||
There was a problem hiding this comment.
This doesn't look like an appropriate fix. In any case, we need a much more detailed explanation here than "permission denied error".
There was a problem hiding this comment.
I think what we need is correct permissions /var/log/mariadb/. You're simply removing the mysql executable.
| @@ -17,6 +17,7 @@ if [ ! -f "$MARIADB_CERT_FILE" ] && [ -f "$MARIADB_KEY_FILE" ] ; then | |||
| fi | |||
|
|
|||
| ln -sf /proc/self/fd/1 /var/log/mariadb/mariadb.log | |||
There was a problem hiding this comment.
Can we maybe use some normal approach to logging rather than this hack? https://mariadb.com/kb/en/error-log/#writing-the-error-log-to-stderr-on-unix suggests it should be possible to just log to stderr.
|
/lgtm I'm approving this to unblock the CI, but could we please take an action items to fix the mysql issue properly as soon as possible? |
Sure, I am working on it. |
Sync with metal3-io/main
This PR aims to solve this error:
__main__.InvalidArguments: --stream provided, but OS is not the Stream version. Please ensure the host is Stream.