Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sushy-tools & vbmc Dockerfiles #267

Merged
merged 1 commit into from
May 27, 2021

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented May 25, 2021

Move sushy-tools & vbmc Dockerfiles to ironic-image repo in order to avoid building their images on every single pull request in metal3-dev-env. This will reduce the time it takes for integration test to run in metal3-dev-env and for master jobs that run every day.
Discussion thread on slack.
After this PR is merged, I will update quay to point ironic-image repo.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2021
@fmuyassarov
Copy link
Member Author

Once this is in, we can merge metal3-io/project-infra#192, which moves local image environment vars under ironic-image repo.

@fmuyassarov
Copy link
Member Author

/cc @dtantsur
/cc @dhellmann
/cc @elfosardo

@fmuyassarov
Copy link
Member Author

/test-integration

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
resources/vbmc/Dockerfile Outdated Show resolved Hide resolved
resources/vbmc/Dockerfile Outdated Show resolved Hide resolved
resources/vbmc/Dockerfile Outdated Show resolved Hide resolved

RUN dnf install -y python3 python3-requests python3-pip && \
curl https://raw.githubusercontent.com/openstack/tripleo-repos/master/tripleo_repos/main.py | python3 - -b master current-tripleo --no-stream && \
dnf upgrade && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I meant "dnf upgrade -y" otherwise it won't go through

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, sorry, copy pasting issue. Fixed.

@fmuyassarov
Copy link
Member Author

/test-integration

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@metal3-io-bot metal3-io-bot merged commit ecad7d3 into metal3-io:master May 27, 2021
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants