Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Riccardo to approvers #274

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Jun 8, 2021

Consensus has been reached in a private thread per the process.

Also removing Julia and Russell per their request.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2021
@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/test-integration
/approve

Approving per consensus on the private thread.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/cc @elfosardo

@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/override test-integration

@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/test-integration

@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/test-integration

@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/retest continuous-integration/travis-ci/pr

@metal3-io-bot
Copy link
Contributor

@dtantsur: No presubmit jobs available for metal3-io/ironic-image@master

In response to this:

/retest continuous-integration/travis-ci/pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Member

bfournie commented Jun 8, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
Consensus has been reached in a private thread per the process.

Also removing Julia and Russell per their request.
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@dtantsur
Copy link
Member Author

dtantsur commented Jun 8, 2021

/test-integration
/lgtm

No, there was no new changes, just travis being stupid...

@metal3-io-bot
Copy link
Contributor

@dtantsur: you cannot LGTM your own PR.

In response to this:

/test-integration
/lgtm

No, there was no new changes, just travis being stupid...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Member

bfournie commented Jun 8, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@metal3-io-bot metal3-io-bot merged commit 6494890 into metal3-io:master Jun 8, 2021
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request May 31, 2022
Bug 2082103: Enable vMedia provisioning of Nokia servers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants