Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cipher_suite_versions config #275

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

iurygregory
Copy link
Member

This commit adds the new ironic configuration option
[ipmi]/cipher_suite_versions.
Allowing ipmi to try different values in case of the
default cipher suite is not supported.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2021
@dtantsur
Copy link
Member

dtantsur commented Jun 9, 2021

/test-integration
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@dtantsur
Copy link
Member

dtantsur commented Jun 9, 2021

Similarly to the openshift patch, please fix the syntax. Python lists are not accepted in conf files, you need 3,17.

This commit adds the new ironic configuration option
``[ipmi]/cipher_suite_versions``.
Allowing ipmi to try different values in case of the
default cipher suite is not supported.
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@iurygregory
Copy link
Member Author

/test-integration

@metal3-io-bot metal3-io-bot merged commit ceb2a8b into metal3-io:master Jun 9, 2021
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request May 31, 2022
Bug 2048672: Enable vMedia provisioning of Nokia servers
@iurygregory iurygregory deleted the cipher_suite branch October 24, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants