Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Wait for expected number of drivers starting API" #279

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Jul 5, 2021

The root cause has been fixed in Ironic.

This reverts commit 3c8acf4.

The root cause has been fixed in Ironic.

This reverts commit 3c8acf4.
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2021
@dtantsur
Copy link
Member Author

dtantsur commented Jul 5, 2021

/test-integration

@andfasano
Copy link
Member

The root cause has been fixed in Ironic.

This reverts commit 3c8acf4.

@dtantsur in which version this problem has been fixed? Does it mean that also this readiness BMO check could be removed?

@dtantsur
Copy link
Member Author

dtantsur commented Jul 6, 2021

Does it mean that also this readiness BMO check could be removed?

No, the BMO check is actually correct. This check here was introduced to work around the bug fixed by https://review.opendev.org/c/openstack/ironic/+/764911.

@andfasano
Copy link
Member

Does it mean that also this readiness BMO check could be removed?

No, the BMO check is actually correct. This check here was introduced to work around the bug fixed by https://review.opendev.org/c/openstack/ironic/+/764911.

Ack, thanks

@elfosardo
Copy link
Member

/test-integration

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2021
@derekhiggins
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@metal3-io-bot metal3-io-bot merged commit b72e06a into metal3-io:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants