Fix missing http port in iso url #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During virtualmedia deploy the port in the iso url is missing causing the deploy to fail. For more info please see https://bugzilla.redhat.com/show_bug.cgi?id=1990316
metal3-io-bot
added
the
size/XS
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test-centos-integration |
4 similar comments
|
/test-centos-integration |
|
/test-centos-integration |
|
/test-centos-integration |
|
/test-centos-integration |
namnx228
reviewed
Aug 10, 2021
| @@ -34,6 +34,7 @@ fi | |||
|
|
|||
| . /bin/ironic-common.sh | |||
|
|
|||
| export HTTP_PORT=${HTTP_PORT:-"80"} | |||
There was a problem hiding this comment.
the default http port should be 80, it then can be changed during deployment
we use 6180 by default in BMO, that's why this was overlooked
|
/test-centos-integration |
|
/lgtm |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Aug 19, 2022
OCPBUGS-171: Fix IRONIC_EXTERNAL_IP when TLS is used for virtual media
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During virtualmedia deploy the port in the iso url is missing causing
the deploy to fail.
For more info please see https://bugzilla.redhat.com/show_bug.cgi?id=1990316