Allow customize base image #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
|
/test-integration |
|
/lgtm |
|
/test-integration |
|
/test-centos-integration |
fmuyassarov
approved these changes
Aug 18, 2021
|
/approve Needs rebase for the Stream and Quay.io changes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, fmuyassarov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
Introduce an ARG BASE_IMAGE that allows customizing the base image used to build the container. This can be useful for quickly changing base image for testing, especially in automated setups.
elfosardo
force-pushed
the
customize-base-image
branch
from
9cf141e
to
ba956d1
Compare
metal3-io-bot
removed
lgtm
|
/test-integration |
|
/test-centos-integration |
|
/cc @namnx228 |
|
/lgtm |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Aug 19, 2022
ironic-proxy: never validate TLS peer name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an ARG BASE_IMAGE that allows customizing the base image used
to build the container.
This can be useful for quickly changing base image for testing,
especially in automated setups.