-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the trailing slash from the heartbeat rule #298
Conversation
Just `/v1/heartbeat` is also valid.
/test-integration |
/assign @fmuyassarov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to fix indentation issue as well on this PR @dtantsur or can I do it in a separate PR too
{% if "HTTP_BASIC_HTPASSWD" in env and env.HTTP_BASIC_HTPASSWD | length %}
AuthType Basic
AuthName "Restricted WSGI area"
AuthUserFile "/etc/ironic/htpasswd"
Require valid-user
{% else %}
Require all granted
{% endif %}
should be
{% if "HTTP_BASIC_HTPASSWD" in env and env.HTTP_BASIC_HTPASSWD | length %}
AuthType Basic
AuthName "Restricted WSGI area"
AuthUserFile "/etc/ironic/htpasswd"
Require valid-user
{% else %}
Require all granted
{% endif %}
I think it's fine to fix separately, it's not even the same spot. |
I've opened #299 for that. |
/cc @maelk |
/cc @elfosardo |
/lgtm |
/approve |
@derekhiggins would you mind to approve once more? Prow should be up again now. Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, fmuyassarov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OCPBUGS-1225: sync BIOS settings fixes
Just
/v1/heartbeat
is also valid.