Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the trailing slash from the heartbeat rule #298

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Sep 6, 2021

Just /v1/heartbeat is also valid.

Just `/v1/heartbeat` is also valid.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2021
@dtantsur
Copy link
Member Author

dtantsur commented Sep 6, 2021

/test-integration

@dtantsur
Copy link
Member Author

dtantsur commented Sep 6, 2021

/assign @fmuyassarov

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to fix indentation issue as well on this PR @dtantsur or can I do it in a separate PR too


        {% if "HTTP_BASIC_HTPASSWD" in env and env.HTTP_BASIC_HTPASSWD | length %}
           AuthType Basic
           AuthName "Restricted WSGI area"
           AuthUserFile "/etc/ironic/htpasswd"
           Require valid-user
        {% else %}
           Require all granted
        {% endif %}

should be

        {% if "HTTP_BASIC_HTPASSWD" in env and env.HTTP_BASIC_HTPASSWD | length %}
            AuthType Basic
            AuthName "Restricted WSGI area"
            AuthUserFile "/etc/ironic/htpasswd"
            Require valid-user
        {% else %}
            Require all granted
        {% endif %}

@dtantsur
Copy link
Member Author

dtantsur commented Sep 6, 2021

I think it's fine to fix separately, it's not even the same spot.

@fmuyassarov
Copy link
Member

I think it's fine to fix separately, it's not even the same spot.

I've opened #299 for that.

@fmuyassarov
Copy link
Member

/cc @maelk

@fmuyassarov
Copy link
Member

/cc @elfosardo

@namnx228
Copy link
Member

namnx228 commented Sep 8, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@derekhiggins
Copy link
Member

/approve

@fmuyassarov
Copy link
Member

@derekhiggins would you mind to approve once more? Prow should be up again now. Thanks.

@derekhiggins
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, fmuyassarov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@metal3-io-bot metal3-io-bot merged commit 237fe95 into master Sep 17, 2021
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Nov 16, 2022
OCPBUGS-1225: sync BIOS settings fixes
@elfosardo elfosardo deleted the dtantsur-v1-heartbeat branch December 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants