Refactor TLS params into a new helper script #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtantsur
requested review from
namnx228 and
elfosardo
and removed request for
namnx228
metal3-io-bot
added
the
size/L
|
/test-integration |
dtantsur
force-pushed
the
tls-params
branch
from
aaa4033
to
13a7244
Compare
|
/test-integration |
|
/test-centos-integration |
|
/approve |
metal3-io-bot
added
the
approved
|
Huh, the link approach does not work. Too bad |
|
/lgtm cancel |
dtantsur
force-pushed
the
tls-params
branch
from
13a7244
to
f367fad
Compare
|
/test-centos-integration |
|
/test-integration |
|
@namnx228 this change has passed CI, could you take another look? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, namnx228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dtantsur
pushed a commit
to dtantsur/ironic-image
that referenced
this pull request
Nov 16, 2022
OCPBUGS-1740: Backport improvements to iDRAC steps to OCP 4.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.