Compare IPs using the short form of IPv6 address #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
|
/lgtm |
|
/test-integration |
metal3-io-bot
added
the
approved
The `ip` command returns the short-form of the IPv6 address so that is what should be used for comparison, even if the user entered an IPv6 address in long-form for PROVISIONING_IP. Use `ipcalc` to get the short-form address. This command can also be used for IPv4 as it strips out the subnet mask for IPv4 and IPv6. For the PROVISIONING_IPs below, this is what would be set for IRONIC_IP: fd8a:aaaa:00bb:c1df::3 -> fd8a:aaaa:bb:c1df::3 fd8a:aaaa:00bb:c1df:0000:0000:0000:0003 -> fd8a:aaaa:bb:c1df::3 fd8a:aaaa:00bb:c1df::3/64 -> fd8a:aaaa:bb:c1df::3 fd8a:aaaa:00bb:c1df::3/128 -> fd8a:aaaa:bb:c1df::3 10.10.10.1 -> 10.10.10.1 10.10.10.1/24 -> 10.10.10.1 10.10.10.1/64 ->
bfournie
force-pushed
the
short-form-ipv6
branch
from
0245774
to
991ac1f
Compare
|
/test-integration |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Nov 16, 2022
Add DNS or GW for use by dnsmasq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ipcommand returns the short-form of the IPv6 address so that is what should be used for comparison, even if the user entered an IPv6 address in long-form for PROVISIONING_IP. Useipcalcto get the short-form address. This command can also be used for IPv4 as it strips out the subnet mask for IPv4 and IPv6.For the PROVISIONING_IPs below, this is what would be set for IRONIC_IP:
fdcc:aaaa:00bb:c1d0::3 -> fdcc:aaaa:bb:c1d0::3
fdcc:aaaa:00bb:c1d0:0000:0000:0000:0003 -> fdcc:aaaa:bb:c1d0::3
fdcc:aaaa:00bb:c1d0::3/64 -> fdcc:aaaa:bb:c1d0::3
fdcc:aaaa:00bb:c1d0::3/128 -> fdcc:aaaa:bb:c1d0::3
10.10.10.1 -> 10.10.10.1
10.10.10.1/24 -> 10.10.10.1
10.10.10.1/64 ->