Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add tag trigger to images building wf #456

Merged
merged 1 commit into from
Jan 15, 2024
Merged

🌱 Add tag trigger to images building wf #456

merged 1 commit into from
Jan 15, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 1, 2023 •
edited
Loading

This PR changes the container build wf in accordance to the params change in https://jenkins.nordix.org/view/Metal3/job/metal3_ironic_container_image_building. With this the wf should trigger new builds not only to merged PRs, but also to git tags creation.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Dec 1, 2023

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@mquhuy mquhuy force-pushed the mquhuy/add-tag-trigger branch 4 times, most recently from 89b3ff5 to f951280 Compare December 7, 2023 08:00
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2023
@tuminoid
Copy link
Member

tuminoid commented Jan 8, 2024

Please add PR description. Otherwise this is LGTM and up to date?

@elfosardo
Copy link
Member

jsut waiting for PR description to approve it

@mquhuy
Copy link
Member Author

mquhuy commented Jan 10, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Jan 10, 2024

Description added. The PR is up to date.

@tuminoid
Copy link
Member

tuminoid commented Jan 10, 2024 •
edited
Loading

Description added. The PR is up to date.

Add the 🌱 in the title. It is now required in ironic-image.

/retitle 🌱 Add tag trigger to images building wf

@tuminoid
Copy link
Member

/retitle 🌱 Add tag trigger to images building wf

@metal3-io-bot metal3-io-bot changed the title Add tag trigger to images building wf 🌱 Add tag trigger to images building wf Jan 10, 2024
tuminoid
tuminoid requested changes Jan 10, 2024
View reviewed changes
.github/workflows/build-images-action.yml Outdated
- 'release-*'
tags:
- 'capm3-v*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not tagging it capm3-* anymore, but using the normal 'vx.y.z`

@mquhuy
Add tag trigger to images building wf
c967fd5 
Signed-off-by: Huy Mai <huy.mai@est.tech>
tuminoid
tuminoid approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@tuminoid
Copy link
Member

/override test-centos-integration-main test-ubuntu-integration-main
Not relevant

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-integration-main test-ubuntu-integration-main
Not relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

/cc @elfosardo @dtantsur
This is good to merge, please check.

@tuminoid
Copy link
Member

@elfosardo @dtantsur
Can we get an approve here?

@tuminoid tuminoid mentioned this pull request Jan 15, 2024
Merged
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@metal3-io-bot metal3-io-bot merged commit 647f300 into metal3-io:main Jan 15, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-tag-trigger branch January 15, 2024 10:29
@tuminoid
Copy link
Member

Disabled image builds in Quay for Ironic, VBMC and sushy-tools images. Images are now build by this workflow+Jenkins.

elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Feb 23, 2024
@openshift-merge-bot
Merge pull request metal3-io#456 from elfosardo/split-okd-ocp
cb723bf 
METAL-902: Split OKD and OCP packages list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @tuminoid @elfosardo @metal3-io-bot