Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 switch markdownlint container to markdownlint-cli2 #474

Merged
merged 1 commit into from
Jan 24, 2024
Merged

📖 switch markdownlint container to markdownlint-cli2 #474

merged 1 commit into from
Jan 24, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 18, 2024 •
edited
Loading

Switch markdownlint container to markdownlint-cli2. This CLI version supports the enable/disable rules in markdown files and allows us to ignore issues locally, not just globally.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch 3 times, most recently from 08ceff6 to 56bcf38 Compare January 23, 2024 12:40
@tuminoid tuminoid changed the title WIP: 🌱 switch markdownlint container to markdownlint-cli2 📖 switch markdownlint container to markdownlint-cli2 Jan 23, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
@tuminoid
Copy link
Member Author

/hold
Needs metal3-io/project-infra#619 to merge first.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
lentzi90
lentzi90 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@elfosardo
Copy link
Member

/approve
feel free to unhold once mardownlint test is fixed

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@tuminoid
Copy link
Member Author

Bumped to 0.9.0 release of the image from 2 days ago.

@tuminoid
switch markdownlint container to markdownlint-cli2
5f77962 
Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from 56bcf38 to 5f77962 Compare January 24, 2024 11:36
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
lentzi90
lentzi90 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@tuminoid
Copy link
Member Author

/retest
Test new linter.

@tuminoid
Copy link
Member Author

/override test-ubuntu-integration-main test-centos-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main test-centos-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/unhold
Good to go.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@metal3-io-bot metal3-io-bot merged commit 3cbaa6d into metal3-io:main Jan 24, 2024
9 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/switch-to-markdownlint-cli2 branch January 24, 2024 14:31
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Apr 23, 2024
@openshift-merge-bot
Merge pull request metal3-io#474 from elfosardo/unix-sockets-415
c5321a9 
OCPBUGS-32389: Use unix sockets by default for reverse proxy communication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @elfosardo @metal3-io-bot @lentzi90