Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add ARG BASE_IMAGE to sushy-tools Dockerfile #491

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

tuminoid
Copy link
Member

To be consistent with other Dockerfiles, and to allow easy replacement of the base image, add ARG BASE_IMAGE to sushy-tools Dockerfile.

To be consistent with other Dockerfiles, and to allow easy replacement
of the base image, add ARG BASE_IMAGE to sushy-tools Dockerfile.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2024
@tuminoid
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main

Unrelated flake.

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tuminoid
Copy link
Member Author

/cc @lentzi90

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@metal3-io-bot metal3-io-bot merged commit eb5b862 into metal3-io:main Mar 28, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/restore-base-image-arg branch March 28, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants