-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Provide scripts to be used as liveness/readiness probes #493
✨ Provide scripts to be used as liveness/readiness probes #493
Conversation
This change is the first step towards metal3-io/baremetal-operator#1528. Through these scripts, we can decouple the validation logic from the pod definition and provide more sophisticated tests in the future. Right now, the same curl command is used (modulo supporting all variants of deploying Ironic). Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
/retitle ✨ Provide scripts to be used as liveness/readiness probes |
/test-centos-integration-main |
/test-centos-integration-main |
1 similar comment
/test-centos-integration-main |
/cc @dtantsur |
/test-centos-integration-main |
/test-centos-integration-main |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Prow triggers being added here: metal3-io/project-infra#693
/test metal3-centos-e2e-integration-test-main |
@mboukhalfa: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ? |
@mboukhalfa: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test metal3-centos-e2e-integration-test-main |
/test metal3-ubuntu-e2e-integration-test-main |
Running with the new keywords, and checking if they actually run the right tests. After that, will change the required tests configs. |
/test-ubuntu-integration-main |
/test-ubuntu-integration-main |
/test-centos-integration-main |
2 similar comments
/test-centos-integration-main |
/test-centos-integration-main |
/test-ironic-image-build |
/test-ubuntu-integration-main |
/test-ironic-image-build |
/test-centos-integration-main |
OK, CI should be now Prow only, removed required Jenkins contexts. |
…clients METAL-1005: [4.16] Update ironic projects and remove cinder and glance clients
This is an automated cherry-pick of #492
/assign tuminoid