Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Use unix sockets by default for reverse proxy communication #494

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Apr 9, 2024

Using additional ports increase the chance of conflicting with something
else on the node and is also potentially less efficient. We have used
Unix sockets via a shared directory in OpenShift for a while without any
complaints. I think upstream should do the same.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

Using additional ports increase the chance of conflicting with something
else on the node and is also potentially less efficient. We have used
Unix sockets via a shared directory in OpenShift for a while without any
complaints. I think upstream should do the same.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

dtantsur commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@tuminoid
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@metal3-io-bot metal3-io-bot merged commit 1cee411 into metal3-io:main Apr 10, 2024
8 checks passed
@tuminoid
Copy link
Member

/cherry-pick release-24.1

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #495

In response to this:

/cherry-pick release-24.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur dtantsur deleted the only-unix branch April 10, 2024 09:17
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Jul 8, 2024
METAL-1049: Download and install sources from local dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants