Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add OWNERS_ALIASES support #510

Merged
merged 1 commit into from
May 17, 2024
Merged

🌱 add OWNERS_ALIASES support #510

merged 1 commit into from
May 17, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #509

/assign tuminoid

@tuminoid
add OWNERS_ALIASES support
9b05a57 
OWNERS_ALIASES groups are needed for fair blunderbuss review requests.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request May 17, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2024
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
Rozzii
Rozzii reviewed May 17, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@Rozzii
Copy link
Member

Rozzii commented May 17, 2024

Integration tests are not important for this PR
/override metal3-centos-e2e-integration-test-release-1-7
/override metal3-ubuntu-e2e-integration-test-release-1-7

@metal3-io-bot
Copy link
Contributor Author

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-centos-e2e-integration-test-release-1-7, metal3-ubuntu-e2e-integration-test-release-1-7

In response to this:

Integration tests are not important for this PR
/override metal3-centos-e2e-integration-test-release-1-7
/override metal3-ubuntu-e2e-integration-test-release-1-7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit bb0917a into metal3-io:release-24.1 May 17, 2024
7 checks passed
@tuminoid tuminoid changed the title [release-24.1] 🌱 add OWNERS_ALIASES support 🌱 add OWNERS_ALIASES support May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metal3-io-bot @dtantsur @Rozzii @tuminoid