Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Disable pip cache #536

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

elfosardo
Copy link
Member

We don't really need to keep pip cache as we don't install more packages with pip after the initial build.
It should reduce the size of the final image of about 50MB.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2024
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

prepare-image.sh Outdated Show resolved Hide resolved
We don't really need to keep pip cache as we don't install more
packages with pip after the initial build.
It should reduce the size of the final image of about 50MB.

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@elfosardo elfosardo changed the title 🌱 Purge pip cache 🌱 Disable pip cache Aug 7, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement on the image size!

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@dtantsur
Copy link
Member

dtantsur commented Aug 8, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@metal3-io-bot metal3-io-bot merged commit d7e63d5 into metal3-io:main Aug 8, 2024
8 of 9 checks passed
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants