fix: don't log a warning for undefined key values, only when typeof i…

…s not string
metalsmith · Feb 25, 2023 · 53feb48 · 53feb48
1 parent c9881d1
commit 53feb48
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -110,7 +110,8 @@ function markdown(options = defaultOptions) {
         if (typeof value === 'string') {
           debug.info('Rendering key "%s" of file "%s"', key.join ? key.join('.') : key, file)
           set(data, key, options.render(globalRefsMarkdown + value, options.engineOptions, { path: file, key }))
-        } else {
+          // log a warning if the key is defined and of an unexpected type, but not if the property simply is not defined
+        } else if (typeof value !== 'undefined') {
           debug.warn('Couldn\'t render key %s of file "%s": not a string', key.join ? key.join('.') : key, file)
         }
       })

diff --git a/test/fixtures/default/src/index.md b/test/fixtures/default/src/index.md
@@ -1,4 +1,6 @@
-
+---
+not_a_string: false
+---
 # A Markdown Post
 
 With some "amazing", _riveting_, **coooonnnntent**.