-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid ax-10--12 in elabg (and sbc6g) #4266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that elabg --> elrab2 doesn't use ax-10--12, metamath#4185 can be partially reverted. elrab2w is then not used
partially reverts many prs (sorry Gino!) fix typos elxp does not use ax-10--12 anymore, so elxpi is now trivial, but is still used for now Notes for a later pr: 1. rru uses less axioms than ru 2. ax-10--12 can be saved from ifeq1,2
Out of curiosity, do you have the diff of the axiom usage file ? (not the total numbers you gave here, but axiom usage of each theorem, gotten with metamath-knife) |
benjub
approved these changes
Oct 5, 2024
I uploaded the diff at https://github.com/icecream17/Stuff/blob/main/math/~ax.diff Edit: Looking at it, it seems like basically most of the 80 usages of ~ elab2g make a few downstream effects |
wlammen
requested changes
Oct 6, 2024
benjub
approved these changes
Oct 6, 2024
wlammen
approved these changes
Oct 6, 2024
avekens
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4257
Commit by commit; #4264 saved several hundred which means the axiom counts in this pr are outdated