Replace syl5reqr with eqtr3di #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in set.mm and iset.mm * Add eqtr3di with the order of the hypotheses switched and the variables renamed. * edit local copy of scripts/minimize to use "minimize_with eqtr3di/may_grow" in place of the normal minimize * Run "show usage syl5reqr" and copy-paste the output to a shell command like for i in x y z; do scripts/minimize $i set.mm; done * For theorems which had been marked "Proof modification is discouraged", add /OVERRIDE on PROVE and SAVE NEW_PROOF in the script and run. Check that the change to use eqtr3di is the only modification printed in the output. (This step was needed for sineq0ALT in set.mm and nothing in iset.mm) * Remove syl5reqr * Repeat for iset.mm
benjub
approved these changes
Oct 10, 2024
|
Going for the quick merge here on the theory that this is the best way to reduce merge conflicts. This is the least proposed rename which involves moving hypotheses. After this I have in mind renaming: and then taking a look at the rest with an eye towards making a new pull request with proposals for what should happen and what should be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in set.mm and iset.mm
Add eqtr3di with the order of the hypotheses switched and the variables renamed.
edit local copy of scripts/minimize to use "minimize_with eqtr3di/may_grow" in place of the normal minimize
Run "show usage syl5reqr" and copy-paste the output to a shell command like for i in x y z; do scripts/minimize $i set.mm; done
For theorems which had been marked "Proof modification is discouraged", add /OVERRIDE on PROVE and SAVE NEW_PROOF in the script and run. Check that the change to use eqtr3di is the only modification printed in the output. (This step was needed for sineq0ALT in set.mm and nothing in iset.mm)
Remove syl5reqr
Repeat for iset.mm