Image storage: serve iso images, lithops support #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove deprecated bootstrap_and_run, refactor dependent scripts * configure policy for image storage bucket on startup * fix sci-test * update graphql Annotation resolver
* remove dataset indexing from ServerAnnotationJob * linting
intsco
changed the title
intsco
changed the title
intsco
changed the title
* thumnail and coloc gen with lithops * simplify ImageStorage init
LachlanStuart
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Thanks for cleaning up the lint issues. Generally looks good.
My comment on ImageStorage._configure_bucket is non-critical - skip it if you don't have time.
Action is only needed on the migration comment if you don't already have a plan for how to deal with the transition period.
intsco
added a commit
that referenced
this pull request
Mar 24, 2021
* feat: serve iso image urls from graphql * remove deprecated bootstrap_and_run, refactor dependent scripts * configure policy for image storage bucket on startup * fix sci-test * update graphql Annotation resolver * fix: test_es_export.py * feat: make image storage work with lithops * remove dataset indexing from ServerAnnotationJob * linting * test: fix * test: fix sci test * fix: code polishing * fix: catch import error * feat: delete ion thumbnail on ds delete * fix: pass ImageStorage objects to lithops functions * thumnail and coloc gen with lithops * simplify ImageStorage init * test: fix colocalization * fix: move image storage bucket configuration to module level init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerAnnotationJob.bootstrap_and_run, refactor dependent scripts.Annotationresolver.pylint==2.7.0complaints.