Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svn-hooks: support commit.conf #144

Merged
merged 2 commits into from
Sep 15, 2014

Conversation

matthewrmshin
Copy link
Member

The current purpose is to switch off branch owner verification and
notification.

The current purpose is to switch off branch owner verification and
notification.
@matthewrmshin
Copy link
Member Author

@benfitzpatrick please review.

mkdir svn-import
echo '[foo]' >svn-import/svnperms.conf
NAME=conf run_tests
mkdir -p 'svn-import'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes?

@benfitzpatrick
Copy link
Contributor

I get a failure for t/fcm-install-svn-hook/01-housekeep-log.t

@matthewrmshin
Copy link
Member Author

I don't get a failure in my environment at work and at home. I'll need to see what is failing under your environment.

@benfitzpatrick
Copy link
Contributor

All the .parsed vs .exp tests fail like this:

--- 01-housekeep-log-0-cmd0.out.parsed  2014-09-15 12:35:01.643439106 +0100
+++ 01-housekeep-log-0-cmd0.out.exp 2014-09-15 12:35:01.646439100 +0100
@@ -1,11 +1,3 @@
-YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/post-commit to /tmp/something/svn-repos/bar/hooks/post-commit
-YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/post-revprop-change to /tmp/something/svn-repos/bar/hooks/post-revprop-change
-YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/pre-commit to /tmp/something/svn-repos/bar/hooks/pre-commit
-YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/pre-revprop-change to /tmp/something/svn-repos/bar/hooks/pre-revprop-change
-YYYY-mm-ddTHH:MM:SSZ: creating symlink: post-commit.log.20140915 -> /tmp/something/svn-repos/bar/log/post-commit.log
-YYYY-mm-ddTHH:MM:SSZ: creating symlink: post-revprop-change.log.20140915 -> /tmp/something/svn-repos/bar/log/post-revprop-change.log
-YYYY-mm-ddTHH:MM:SSZ: creating symlink: pre-commit.log.20140915 -> /tmp/something/svn-repos/bar/log/pre-commit.log
-YYYY-mm-ddTHH:MM:SSZ: creating symlink: pre-revprop-change.log.20140915 -> /tmp/something/svn-repos/bar/log/pre-revprop-change.log
 YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/post-commit to /tmp/something/svn-repos/foo/hooks/post-commit
 YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/post-revprop-change to /tmp/something/svn-repos/foo/hooks/post-revprop-change
 YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/pre-commit to /tmp/something/svn-repos/foo/hooks/pre-commit
@@ -14,3 +6,11 @@
 YYYY-mm-ddTHH:MM:SSZ: creating symlink: post-revprop-change.log.20140915 -> /tmp/something/svn-repos/foo/log/post-revprop-change.log
 YYYY-mm-ddTHH:MM:SSZ: creating symlink: pre-commit.log.20140915 -> /tmp/something/svn-repos/foo/log/pre-commit.log
 YYYY-mm-ddTHH:MM:SSZ: creating symlink: pre-revprop-change.log.20140915 -> /tmp/something/svn-repos/foo/log/pre-revprop-change.log
+YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/post-commit to /tmp/something/svn-repos/bar/hooks/post-commit
+YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/post-revprop-change to /tmp/something/svn-repos/bar/hooks/post-revprop-change
+YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/pre-commit to /tmp/something/svn-repos/bar/hooks/pre-commit
+YYYY-mm-ddTHH:MM:SSZ: copy /opt/fcm/etc/svn-hooks/pre-revprop-change to /tmp/something/svn-repos/bar/hooks/pre-revprop-change
+YYYY-mm-ddTHH:MM:SSZ: creating symlink: post-commit.log.20140915 -> /tmp/something/svn-repos/bar/log/post-commit.log
+YYYY-mm-ddTHH:MM:SSZ: creating symlink: post-revprop-change.log.20140915 -> /tmp/something/svn-repos/bar/log/post-revprop-change.log
+YYYY-mm-ddTHH:MM:SSZ: creating symlink: pre-commit.log.20140915 -> /tmp/something/svn-repos/bar/log/pre-commit.log
+YYYY-mm-ddTHH:MM:SSZ: creating symlink: pre-revprop-change.log.20140915 -> /tmp/something/svn-repos/bar/log/pre-revprop-change.log

To ensure tests are consistent.
@matthewrmshin
Copy link
Member Author

Added more sort.

benfitzpatrick added a commit that referenced this pull request Sep 15, 2014
@benfitzpatrick benfitzpatrick merged commit db99680 into metomi:master Sep 15, 2014
@matthewrmshin matthewrmshin deleted the commit.conf branch September 15, 2014 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants