Use dd conv=fsync to create backup and dump
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that backup and dump data is written to disk before returning a good status.
|
@benfitzpatrick please review. |
| echo "svnadmin dump -r$REV --incremental --deltas $REPOS | gzip \\" | ||
| echo " | (dd 'conv=fsync' \"of=$TMP_DUMP\" 2>/dev/null)" | ||
| svnadmin dump "-r$REV" --incremental --deltas "$REPOS" | gzip \ | ||
| | (dd 'conv=fsync' "of=$TMP_DUMP" 2>/dev/null) || RET_CODE=$? |
There was a problem hiding this comment.
The RET_CODE only gets set if the dd fails:
$PROMPT: false | true || echo oh no
gives nothing.
There was a problem hiding this comment.
Hopefully, any failure in the pipeline will result in a zero sized dump, which will be picked up in the next few lines.
benfitzpatrick
added a commit
that referenced
this pull request
Sep 25, 2014
Use `dd conv=fsync` to create backup and dump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that backup and dump data is written to disk before returning a
good status.