FCM1: fix config parser lc problem #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has started to given out a lot of warnings in newer versions of Perl5.
|
@tomgreen66 Do you think you can test this branch in your environment? |
|
@matthewrmshin I have just run it through an incremental build of the UM test job (vn8.5) and it still generates the following: 3 Use of uninitialized value in uc at /software/tools/fcm/fix-fcm1-cfg-lc/bin/../lib/FCM1/BuildSrc.pm line 409.
22904 Use of uninitialized value in uc at /software/tools/fcm/fix-fcm1-cfg-lc/bin/../lib/FCM1/CfgFile.pm line 244.Does that help understand the issue - not sure how I missed those if they were being generated with the earlier messages. |
|
I'll take another look. |
|
@tomgreen66 please take another look. |
|
@matthewrmshin - just rerun the test (and also a forced rebuild) and it seems to have fixed the warnings so thats great and a big thanks from me. Is there anything else I can do? |
matthewrmshin
added a commit
that referenced
this pull request
Nov 6, 2014
FCM1: fix config parser lc problem
|
@tomgreen66 I'll create an FCM release in the not so distant future. |
matthewrmshin
added a commit
to matthewrmshin/fcm
that referenced
this pull request
Dec 2, 2014
Configuration logic was broken by metomi#156.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has started to given out a lot of warnings in newer versions of Perl5.
Fix #153.