fcm make: build: flexible checksum method #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
fcm-make-flexible-checksum-method
branch
from
f78cad3
to
c047d1e
Compare
MD5 or one of SHA algorithms in Digest::SHA.
matthewrmshin
force-pushed
the
fcm-make-flexible-checksum-method
branch
from
c047d1e
to
d022322
Compare
|
@benfitzpatrick please review. |
| @@ -695,7 +711,7 @@ Returns a file handle for loading contents from $path. | |||
|
|
|||
| =item $u->file_md5($path) | |||
|
|
|||
| Returns the MD5 checksum of $path. | |||
| Deprecated. Equivalent to $u->file_checksum($path, 'md5'). | |||
There was a problem hiding this comment.
Why deprecate it? Why not delete it?
There was a problem hiding this comment.
Just in case something else like GEN is still using this library.
|
OK, looks fine. Running the test-battery... |
benfitzpatrick
added a commit
that referenced
this pull request
Oct 12, 2015
…-method fcm make: build: flexible checksum method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MD5 or one of SHA algorithms in Digest::SHA.