Improve version related functions #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcm make: new `required-version` declaration. fcm version: now displays FCM_HOME location, consistent with `rose version`.
matthewrmshin
force-pushed
the
fcm-make-require-version
branch
from
e567ed9
to
a524c4c
Compare
|
@benfitzpatrick @scwhitehouse please review. |
|
Looks fine to me, passes the test battery. |
| my ($min_version, $max_version) = shellwords($entry->get_value()); | ||
| if ( $min_version gt $version | ||
| || defined($max_version) && $version gt $max_version | ||
| ) { |
There was a problem hiding this comment.
Just to make sure I understand, is this doing a text comparison on the strings (rather than numeric, as 2015.12.0 isn't a number)? And if one value is set as require-version it's taken as a minimum, and if there are two the first is a minimum and the second is a maximum?
There was a problem hiding this comment.
That sounds about right. (Obviously, the numeric comparison will not work if we issue more than 10 formal releases in a single month, but I don't think we'll ever get to that for FCM.)
|
In which case this looks sensible to me |
scwhitehouse
added a commit
that referenced
this pull request
Feb 10, 2016
Improve version related functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcm make: new
required-versiondeclaration.fcm version: now displays FCM_HOME location, consistent with
rose version.Close #113.