Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: replaces gcexportdata.NewImporter #716

Closed
wants to merge 1 commit into from
Closed

WIP: replaces gcexportdata.NewImporter #716

wants to merge 1 commit into from

Conversation

chavacava
Copy link
Collaborator

Closes #713

@chavacava
working version
3e427a1 
needs to fix tests data
needs to cleanup code
@chavacava chavacava marked this pull request as draft July 21, 2022 20:08
@chavacava chavacava mentioned this pull request Jul 21, 2022
Closed
@git-hulk git-hulk mentioned this pull request Jul 26, 2022
Open
@mgechev
Copy link
Owner

mgechev commented Aug 7, 2022

Closing since looks like we fixed the issue with the default importer.

@mgechev mgechev closed this Aug 7, 2022
@git-hulk
Copy link
Contributor

git-hulk commented Aug 16, 2022 •
edited
Loading

Hello @mgechev, looks the default importer still can't load symbols outside the package which was mentioned in #680. Did I miss something?

@mgechev
Copy link
Owner

mgechev commented Aug 18, 2022

@git-hulk #723 addressed #713 not #680. #680 is still open.

@mgechev mgechev deleted the fix/713 branch August 18, 2022 19:20
@git-hulk
Copy link
Contributor

@git-hulk #723 addressed #713 not #680. #680 is still open.

Thanks @mgechev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcexportdata.NewImporter: huge impact on performance
3 participants
@chavacava @mgechev @git-hulk