Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested-structs: show issue with "struct{}" detection #828

Closed
wants to merge 1 commit into from

Conversation

sbunce
Copy link

@sbunce sbunce commented May 16, 2023

Background

This pull request is to demonstrate issue in #824

It seems like the intent is to not fail on "struct{}".

Copy link
Owner

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this file contains broken syntax

@sbunce
Copy link
Author

sbunce commented May 22, 2023

The syntax is go generics.

I put it on go playground here.
https://go.dev/play/p/XSgqTLsjaS_N

I think the 1.17 test is failing because generics was introduced in go1.18.

@chavacava
Copy link
Collaborator

Closing this PR. The example is already mentioned in #824
Thanks!

@chavacava chavacava closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants