feat: add support for enforce-slice-style rule #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisvmedia
force-pushed
the
feature/enforce-slice-type
branch
from
ca3e2ac
to
d961ed3
Compare
chavacava
requested changes
Sep 23, 2023
There was a problem hiding this comment.
Hi @denisvmedia, thanks for the PR.
Test are not passing because one testdata file has expected issue messages not matching with actual messages.
One think you could do in testdata is to use the same set of slice declarations for all test cases (any, make, and literal) and at each testdata file just modify accordingly the // MATCH /... / annotations
|
@chavacava yeah, you a right, thanks. I added this suffix but forgot to fix one of the test cases. Now fixed. |
|
Merged. Thank you @denisvmedia. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #898.