Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified IB commission calculation #237

Closed
wants to merge 1 commit into from
Closed

Modified IB commission calculation #237

wants to merge 1 commit into from

Conversation

MagicEthan
Copy link

Keep consistent with calculation method on IB website:

https://www.interactivebrokers.co.uk/en/index.php?f=1590&p=stocks1

@coveralls
Copy link

coveralls commented Oct 23, 2017

Coverage Status

Coverage remained the same at 57.143% when pulling de05a97 on MagicEthan:ethansong into dfa6693 on mhallsmoore:master.

@mhallsmoore
Copy link
Owner

Hi @MagicEthan,

Thank you for this! I'll make sure to include this change in a subsequent version of QSTrader when we reimplement the IB functionality.

Kind regards,

Mike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants