Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden files created by Textmate (a editor for Mac) #47

Closed
wants to merge 0 commits into from

Conversation

moonlight16
Copy link
Contributor

Purely for selfish reasons :P

...and possibly for the sake of others that use Textmate as well.

@femtotrader
Copy link
Contributor

It shouldn't be merged... because it's not only changing .gitignore
That's probably an issue on your side.
I think you need to rebase

@mhallsmoore
Copy link
Owner

It contains an example of running a strategy via Quandl data, using a Quandl PriceHandler. @jacohn16 - thanks for adding this! I'll need to sit down for a bit and merge in the changes manually, as the master has changed somewhat. Rebasing is probably a good idea, as suggested by @femtotrader.

@moonlight16
Copy link
Contributor Author

I'm confused why this is happening. So first I made the change in .gitignore and pushed the commit from my local repo to Github. Then I opened the PR. Then I tried to commit the 2nd change (quandl price handler implementation), but I wanted to commit only to my forked repo. I didn't want to submit a PR for this yet, because I wanted to further develop the futures pricing....and request PR once its all ready.

But where did I do wrong here? When you say I should rebase. How exactly should the rebase be done? (sorry about the newbie questions)

This is the bit of history on my local master:

@femtotrader
Copy link
Contributor

You should make a local copy of your code and remove your commits.

$ git reset --soft HEAD~2
$ git push -f

CAUTION ! DO THIS AT YOUR OWN RISK!!!

@femtotrader
Copy link
Contributor

I suggest to always work in a branch for new features (not master)
even in your repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants