Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added six Queue import #63

Closed
wants to merge 1 commit into from
Closed

Added six Queue import #63

wants to merge 1 commit into from

Conversation

muke5hy
Copy link

@muke5hy muke5hy commented Jun 27, 2016

As six is already in dependency i.e. requirements.txt added

from six.moves.queue import Queue as queue

@femtotrader
Copy link
Contributor

I think this should be broken because of

except queue.Empty:

@mhallsmoore please log to Travis CI and enable CI for this repository!

@femtotrader
Copy link
Contributor

I suggest to close this PR.
six doesn't really help as we need queue.Empty
moreover I suggest to only merge PR that pass CI.

@mhallsmoore
Copy link
Owner

Hi @muke5hy, @femtotrader,

I think @femtotrader is right in that we don't need six any more. The branch also merge conflicts.

I'll close this PR, but we can re-open if we need to.

Mike.

@mhallsmoore mhallsmoore closed this Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants