Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update execution_handler.py #73

Merged
merged 1 commit into from
Jul 2, 2016
Merged

Update execution_handler.py #73

merged 1 commit into from
Jul 2, 2016

Conversation

femtotrader
Copy link
Contributor

Remove unused datetime import

Remove unused datetime import
@mhallsmoore mhallsmoore merged commit 0d59bfc into mhallsmoore:master Jul 2, 2016
@mhallsmoore
Copy link
Owner

I didn't realise the build was considered "failed" if it doesn't pass PEP8! Although, I guess that's pretty useful.

@femtotrader
Copy link
Contributor Author

femtotrader commented Jul 2, 2016

Yes the build was considered "failed" if it doesn't pass PEP8 because fixing flake8 error help to keep a clean code.
PEP8 checking is done after unit tests so you can see in Travis builds if unit tests are passing correctly because I think it's more important to have code that pass unit test than code that pass both...
but to be merged code should pass both.

@ryankennedyio
Copy link
Contributor

I find linting to be very helpful in dynamically typed languages - agree RE PEP8 compliance.

@femtotrader is there an easy a way to simulate the travis-CI build locally, before we push code up to branches here?

@mhallsmoore
Copy link
Owner

Agreed. The project will attract more good software developers if we can keep code clean and unit tests passing.

@femtotrader
Copy link
Contributor Author

femtotrader commented Jul 2, 2016

@ryankennedyio simulate the Travis-CI build locally ? I never do this...
Travis rely on Docker containers.

I know that some Python dev use tox http://tox.readthedocs.io/en/latest/ to manage test, deployment...

You can also urge git to run some command lines before commit (run tests, PEP8...)

but I personaly don't do it and rely heavily on Travis.

I also don't use virtualenv (I use conda from Anaconda Python)

@femtotrader femtotrader deleted the patch-2 branch July 2, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants