Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some compiler options work with mingw too #1381

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Make some compiler options work with mingw too #1381

merged 1 commit into from
Aug 7, 2019

Conversation

joankaradimov
Copy link
Contributor

This moves some code in setup.py outside an if not build_ext.mingw32 block.

It also changes /D compiler options to -D so that they work both in MSVC and in MinGW/gcc.

@joankaradimov joankaradimov mentioned this pull request Jul 30, 2019
Merged
@mhammond mhammond merged commit f95adaa into mhammond:master Aug 7, 2019
vernondcole pushed a commit to vernondcole/pywin32 that referenced this pull request Nov 16, 2019
@joankaradimov @vernondcole
Make some compiler options work with mingw too (mhammond#1381)
94330bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joankaradimov @mhammond