Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diable API if auth is enabled #1225

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Diable API if auth is enabled #1225

merged 3 commits into from
Jul 1, 2022

Conversation

mher
Copy link
Owner

@mher mher commented Jul 1, 2022

  • Disable API if authentication is enabled
  • Deprecate WebSocket API

@mher mher merged commit 9829f05 into master Jul 1, 2022
@Tudyx
Copy link

Tudyx commented Sep 9, 2022

Please could you indicate how to use the API and still have authentication?
My use case is i want to give access to the web monitoring to a limited number of persons and also use the API to automate some task.

@WillKoehrsen
Copy link

WillKoehrsen commented Oct 11, 2022

The API disabling seems like a misunderstanding of the recommendation from the blog post that identified security issues.

That blog post (by @tprynn) states:

Disable the API unless authentication is configured for Flower

This PR disables the API if authentication is configured, which is the opposite of the recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants