build: Generate zsh completion only for macos.

michael-simons · Dec 20, 2021 · e4663c7 · e4663c7
1 parent afb8ce8
commit e4663c7
Show file tree

Hide file tree

Showing 6 changed files with 88 additions and 34 deletions.
diff --git a/bin/add-zsh-completion-osx.sh b/bin/add-zsh-completion-osx.sh
@@ -0,0 +1,15 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+cp $1/$2 $1/_neo4j-migrations
+
+ZSH_SHIM="
+compopt() {
+  complete \$@
+}
+
+_complete_neo4j-migrations
+"
+
+echo "$ZSH_SHIM" >> $1/_neo4j-migrations
diff --git a/bin/generate-completion.sh b/bin/generate-completion.sh
diff --git a/neo4j-migrations-cli/pom.xml b/neo4j-migrations-cli/pom.xml
@@ -13,6 +13,7 @@
 	<description>CLI module, packaged as JVM and native assemblies.</description>
 
 	<properties>
+		<assembly-suffix />
 		<covered-ratio-complexity>0.1</covered-ratio-complexity>
 		<covered-ratio-instructions>0.03</covered-ratio-instructions>
 		<executable-suffix/>
@@ -115,14 +116,14 @@
 						</goals>
 						<phase>package</phase>
 						<configuration combine.self="override">
-							<executable>${project.basedir}/../bin/generate-completion.sh</executable>
+							<executable>java</executable>
 							<arguments>
 								<argument>-classpath</argument>
 								<classpath/>
 								<argument>${name-of-main-class}</argument>
 								<argument>generate-completion</argument>
-								<argument>${project.build.directory}</argument>
 							</arguments>
+							<outputFile>target/neo4j-migrations_completion</outputFile>
 						</configuration>
 					</execution>
 				</executions>
@@ -198,6 +199,41 @@
 				<executable-suffix>.exe</executable-suffix>
 			</properties>
 		</profile>
+		<profile>
+			<id>osx</id>
+			<activation>
+				<os>
+					<family>mac</family>
+				</os>
+			</activation>
+			<properties>
+				<assembly-suffix>-osx</assembly-suffix>
+			</properties>
+			<build>
+				<plugins>
+					<plugin>
+						<groupId>org.codehaus.mojo</groupId>
+						<artifactId>exec-maven-plugin</artifactId>
+						<executions>
+							<execution>
+								<id>add-zsh-completion</id>
+								<goals>
+									<goal>exec</goal>
+								</goals>
+								<phase>package</phase>
+								<configuration combine.self="override">
+									<executable>${project.basedir}/../bin/add-zsh-completion-osx.sh</executable>
+									<arguments>
+										<argument>${project.build.directory}</argument>
+										<argument>neo4j-migrations_completion</argument>
+									</arguments>
+								</configuration>
+							</execution>
+						</executions>
+					</plugin>
+				</plugins>
+			</build>
+		</profile>
 		<profile>
 			<id>native</id>
 			<activation>
@@ -241,7 +277,7 @@
 									<finalName>neo4j-migrations-${project.version}-${os.detected.classifier}</finalName>
 									<attach>false</attach>
 									<descriptors>
-										<descriptor>src/main/assembly/assembly-native.xml</descriptor>
+										<descriptor>src/main/assembly/assembly-native${assembly-suffix}.xml</descriptor>
 									</descriptors>
 								</configuration>
 							</execution>

diff --git a/neo4j-migrations-cli/src/main/assembly/assembly-java.xml b/neo4j-migrations-cli/src/main/assembly/assembly-java.xml
@@ -21,11 +21,6 @@
             <source>${project.build.directory}/neo4j-migrations_completion</source>
             <outputDirectory>completion</outputDirectory>
         </file>
-        <file>
-            <source>${project.build.directory}/_neo4j-migrations</source>
-            <destName>_neo4j-migrations</destName>
-            <outputDirectory>completion/zsh</outputDirectory>
-        </file>
     </files>
     <fileSets>
         <fileSet>

diff --git a/neo4j-migrations-cli/src/main/assembly/assembly-native-osx.xml b/neo4j-migrations-cli/src/main/assembly/assembly-native-osx.xml
@@ -0,0 +1,34 @@
+<?xml version="1.0"?>
+<assembly
+        xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
+    <id>dist</id>
+    <formats>
+        <format>zip</format>
+    </formats>
+    <files>
+        <file>
+            <source>${project.parent.basedir}/LICENSE.txt</source>
+            <destName>LICENSE</destName>
+            <outputDirectory/>
+        </file>
+        <file>
+            <source>src/main/assembly/README</source>
+            <outputDirectory/>
+        </file>
+        <file>
+            <source>${project.build.directory}/neo4j-migrations_completion</source>
+            <outputDirectory>completion</outputDirectory>
+        </file>
+        <file>
+            <source>${project.build.directory}/_neo4j-migrations</source>
+            <destName>_neo4j-migrations</destName>
+            <outputDirectory>completion/zsh</outputDirectory>
+        </file>
+        <file>
+            <source>${project.build.directory}/neo4j-migrations${executable-suffix}</source>
+            <outputDirectory>./bin</outputDirectory>
+        </file>
+    </files>
+</assembly>
diff --git a/neo4j-migrations-cli/src/main/assembly/assembly-native.xml b/neo4j-migrations-cli/src/main/assembly/assembly-native.xml
@@ -21,11 +21,6 @@
             <source>${project.build.directory}/neo4j-migrations_completion</source>
             <outputDirectory>completion</outputDirectory>
         </file>
-        <file>
-            <source>${project.build.directory}/_neo4j-migrations</source>
-            <destName>_neo4j-migrations</destName>
-            <outputDirectory>completion/zsh</outputDirectory>
-        </file>
         <file>
             <source>${project.build.directory}/neo4j-migrations${executable-suffix}</source>
             <outputDirectory>./bin</outputDirectory>