Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe a bug mxml-4.0.2/mxml-set.c lines 266 and 269 #322

Closed
lbinic opened this issue Apr 8, 2024 · 2 comments
Closed

Maybe a bug mxml-4.0.2/mxml-set.c lines 266 and 269 #322

lbinic opened this issue Apr 8, 2024 · 2 comments
Assignees
@michaelrsweet
Labels
bug Something isn't working priority-medium
Milestone
Stable

Comments

@lbinic
Copy link

lbinic commented Apr 8, 2024 

266   if (node && node->type == MXML_TYPE_ELEMENT && node->child && node->child->type == MXML_TYPE_COMMENT)
267   node = node->child;
268
269  if (!node || node->type != MXML_TYPE_COMMENT)

We are in mxmlSetDeclarationf(), so probably it is MXML_TYPE_DECLARATION instead of MXML_TYPE_COMMENT.
@michaelrsweet
Copy link
Owner

Whoops, yes that needs to be fixed.

@michaelrsweet michaelrsweet self-assigned this Apr 8, 2024
@michaelrsweet michaelrsweet added bug Something isn't working priority-medium labels Apr 8, 2024
@michaelrsweet michaelrsweet added this to the Stable milestone Apr 8, 2024
michaelrsweet added a commit that referenced this issue Apr 21, 2024
@michaelrsweet
Fixed mxmlSetDeclarationf implementation (Issue #322)
0c97db4
@michaelrsweet
Copy link
Owner

[master 0c97db4] Fixed mxmlSetDeclarationf implementation (Issue #322)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
bug Something isn't working priority-medium
Projects
None yet
Milestone
Stable
Development

No branches or pull requests
2 participants
@michaelrsweet @lbinic