Skip to content

Commit

Permalink
Require an old IPython for old Python versions
Browse files Browse the repository at this point in the history
This works around a packaging bug in IPython 8.13: it drops support for
Python 3.8, but still declares support for 3.8 in its `python_requires`,
so `pip` installs the new version even for Python versions that don't
support it.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
  • Loading branch information
godlygeek authored and Gus Monod committed May 1, 2023
1 parent 44d1270 commit 62fb9ad
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions requirements-docs.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
IPython
IPython < 8.13; python_version < '3.9'
sphinx
sphinx-autobuild
sphinx-argparse
Expand Down
1 change: 1 addition & 0 deletions requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ greenlet; python_version < '3.11'
pytest
pytest-cov
ipython
ipython < 8.13; python_version < '3.9'
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ def build_js_files(self):
]
docs_requires = [
"IPython",
"IPython < 8.13; python_version < '3.9'",
"bump2version",
"sphinx",
"furo",
Expand All @@ -115,6 +116,7 @@ def build_js_files(self):
"pytest",
"pytest-cov",
"ipython",
"ipython < 8.13; python_version < '3.9'",
]

benchmark_requires = [
Expand Down

0 comments on commit 62fb9ad

Please sign in to comment.