Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]应该需要改成mhttp.WithRegistry(s.opts.Registry), #1436

Closed
yuanzhangcai opened this issue Mar 29, 2020 · 1 comment
Closed

[BUG]应该需要改成mhttp.WithRegistry(s.opts.Registry), #1436

yuanzhangcai opened this issue Mar 29, 2020 · 1 comment

Comments

@yuanzhangcai
Copy link

yuanzhangcai commented Mar 29, 2020 •
edited
Loading

go-micro/web/service.go

Line 271 in 8282e78

mhttp.WithRegistry(registry.DefaultRegistry),

应该需要改成mhttp.WithRegistry(s.opts.Registry),
@yuanzhangcai yuanzhangcai changed the title 这里有个bug，是不是应该需要改成mhttp.WithRegistry(s.opts.Registry), [bug]应该需要改成mhttp.WithRegistry(s.opts.Registry), Mar 29, 2020
@yuanzhangcai yuanzhangcai changed the title [bug]应该需要改成mhttp.WithRegistry(s.opts.Registry), [BUG]应该需要改成mhttp.WithRegistry(s.opts.Registry), Mar 29, 2020
@crazybber crazybber mentioned this issue Apr 2, 2020
Merged
@yuanzhangcai yuanzhangcai reopened this Apr 2, 2020
vtolstov pushed a commit that referenced this issue Apr 5, 2020
@crazybber
fix: use registry from opts not use default directly:(#1436) (#1468)
31a1ea6 
web: use passed user registry, or default
@crazybber
Copy link
Contributor

@asim @vtolstov @ben-toogood we can close this now.

@asim asim closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asim @crazybber @yuanzhangcai