Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling micro run for subfolders #1510

Merged
merged 9 commits into from
Apr 9, 2020
Merged

Enabling micro run for subfolders #1510

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f18fc3e
Enabling micro run for subfolders
crufter Apr 9, 2020
bfdc9d1
Merge branch 'master' into micro-run-fix
crufter Apr 9, 2020
317a97e
Use source instead of os.Args[2]
crufter Apr 9, 2020
e6e6b45
Merge branch 'micro-run-fix' of github.com:crufter/go-micro into micr…
crufter Apr 9, 2020
61a747f
Works now
crufter Apr 9, 2020
3b5c0e1
Merge branch 'master' into micro-run-fix
crufter Apr 9, 2020
bff6e99
PR comments
crufter Apr 9, 2020
85592ac
Merge branch 'micro-run-fix' of github.com:crufter/go-micro into micr…
crufter Apr 9, 2020
ccf1c8a
WorkDir -> Dir
crufter Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Works now
  • Loading branch information
@crufter
crufter committed Apr 9, 2020
commit 61a747fcbcf42c5f0fbc6d99999980b52585893f
7 changes: 1 addition & 6 deletions runtime/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,12 +195,7 @@ func (r *runtime) Create(s *Service, opts ...CreateOption) error {
o(&options)
}

dir, err := filepath.Abs(filepath.Dir(os.Args[0]))
if err != nil {
return err
}

options.WorkDir = filepath.Join(dir, s.Source)
options.WorkDir = s.Source
if len(options.Command) == 0 {
options.Command = []string{"go"}
options.Args = []string{"run", "."}
Expand Down
1 change: 1 addition & 0 deletions runtime/local/process/os/os.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ func (p *Process) Fork(exe *process.Executable) (*process.PID, error) {

cmd.Dir = exe.WorkDir
// set env vars
cmd.Env = append(cmd.Env, os.Environ()...)
cmd.Env = append(cmd.Env, exe.Env...)

// create process group
Expand Down