broker: swap default broker from eats to http #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asim why we have Handle option in go-plugins/broker/http ? i don't see any usage of it |
|
It was to enable adding a handler for things like prometheus |
asim
reviewed
Apr 11, 2020
|
do we need this option too? i'm ask because this is not default broker option, but it exposed in broker package |
|
may be move it to go-micro/broker/http ? |
|
yea add the options |
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
|
done |
asim
reviewed
Apr 11, 2020
asim
reviewed
Apr 11, 2020
asim
reviewed
Apr 11, 2020
|
Merge? |
|
waiting for ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasiliy Tolstov v.tolstov@unistack.org