Add grpc transport #485
Merged
Add grpc transport #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When is code merged? |
|
Not for a while, we're assessing the best way to support grpc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not yet merging this!
We want to add grpc as a default transport but its unclear in what form. People mostly want it for transparent proxying but I'm not really sure we can support that. Go Micro and grpc-go are competing frameworks. The interop may never be clean so we need to identify how we're moving forward.
This PR adds the grpc transport from go-plugins. We define a client/server which takes a transport message. This has good performance characteristics but doesn't really deal with the proxy case people want.
Open to discussion.