Add consul-specific option for config (as registry) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asim
reviewed
Jun 25, 2019
config/source/consul/options.go
Outdated
| @@ -61,3 +63,13 @@ func WithToken(p string) source.Option { | |||
| o.Context = context.WithValue(o.Context, tokenKey{}, p) | |||
| } | |||
| } | |||
|
|
|||
| // WithConsulConfig set consul-specific options | |||
| func WithConsulConfig(c *api.Config) source.Option { | |||
There was a problem hiding this comment.
Please specify as WithConfig considering this is already in the consul package
asim
reviewed
Jun 25, 2019
config/source/consul/options.go
Outdated
| @@ -11,6 +12,7 @@ type prefixKey struct{} | |||
| type stripPrefixKey struct{} | |||
| type dcKey struct{} | |||
| type tokenKey struct{} | |||
| type consulConfigKey struct{} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul default
http.ClientuseTimeoutas 0, which might cause hang issue if server outage occur, as indicated by this blog.User should have the ability to do finer grained config when using consul as config backend.