Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #3

Closed
wants to merge 1 commit into from
Closed

Update readme.md #3

wants to merge 1 commit into from

Conversation

codersjj
Copy link

Add CSS to prevent text overflow.

Normally, this style should be inherited from ancestor elements(In github-markdown-css, this style is set in .markdown-body.). However, if no ancestor element has set this style, it's better to set it here.

See: https://github.com/sindresorhus/github-markdown-css/blob/main/github-markdown.css#L106

Add CSS to prevent text overflow.

Signed-off-by: codersjj <44868357+codersjj@users.noreply.github.com>
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jul 31, 2023
@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #3 (a0f5b07) into main (01620d2) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          896       896           
=========================================
  Hits           896       896           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wooorm
Copy link
Member

wooorm commented Jul 31, 2023

Hmm, I don’t think that’s a good idea. There are tons of things that could be done to make typography better. This seems like a slippery slope. If we’re going to include things from .markdown-body here, why not font-size, -webkit-text-size-adjust, color?

This section already links to that project for when folks want the exact same CSS as GH. The CSS included here is more to make footnotes work?

@codersjj
Copy link
Author

Hmm, I don’t think that’s a good idea. There are tons of things that could be done to make typography better. This seems like a slippery slope. If we’re going to include things from .markdown-body here, why not font-size, -webkit-text-size-adjust, color?

This section already links to that project for when folks want the exact same CSS as GH. The CSS included here is more to make footnotes work?

Alright, we should indeed only include the minimal necessary styles.

@wooorm wooorm closed this Jul 31, 2023
@wooorm wooorm added the 👀 no/external This makes more sense somewhere else label Jul 31, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Hi team! Could you describe why this has been marked as external?

Thanks,
— bb

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 👋 phase/new Post is being triaged automatically labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

3 participants