Make the regular changes for 4.0.0 #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, there are 2 issues - The test-kotlin project just fails, and I cannot see what it is missing - It seems that activeSpan() always returns null, so the tags are not being added in the tests
timyates
added
the
relates-to: build
65 tasks
graemerocher
reviewed
Nov 9, 2022
| @@ -56,6 +56,8 @@ awssdk-core = { module = 'software.amazon.awssdk:sdk-core' } | |||
|
|
|||
| micronaut-aws-bom = { module = 'io.micronaut.aws:micronaut-aws-bom' } | |||
|
|
|||
| javax-annotation-api = { module = "javax.annotation:javax.annotation-api" } | |||
There was a problem hiding this comment.
this shouldn't be used
There was a problem hiding this comment.
Any idea how to get around grpc annotating classes it creates with @javax.annotation.Generated?
There was a problem hiding this comment.
Seems no way until this issue will be resolved: grpc/grpc-java#9179
|
Kudos, SonarCloud Quality Gate passed!
|
|
Superseded by #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, there are 2 issues