ci: Temporarily re-add lerna to package.json #16036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
This reverts commit 9312120.
github-actions
bot
added
the
dependencies
alexvy86
changed the title
Abe27342
approved these changes
Jun 16, 2023
|
Upstream issue has been fixed. Closing this as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@octokit/restshipped a breaking change (one of its deps now requires Node >=18 instead of >=14) in a patch release that is being installed transitively through Lerna's dependencies when we donpx lerna. This is causing our CI runs to fail because they use node 16.@octokit/resthas an issue open which might see the breaking change reverted, but in the meantimewe're changing the version of Lerna we use to one that doesn't end up bringing in the broken dependency to unblock our CI per the workaround here.we're re-adding Lerna to our root dev deps and pinning the broken dep to a version before the breaking change.We should revert the changes in this PR when possible, i.e. when
@octokit/restreleases a fixed version, since we're working towards removing Lerna from the repo at some point.