-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit events from Unhydrated SharedTree Nodes #22661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Issues related to distributed data structures
area: dds: tree
changeset-present
base: main
PRs targeted against main branch
labels
Sep 27, 2024
jzaffiro
reviewed
Sep 27, 2024
⯅ @fluid-example/bundle-size-tests: +1.18 KB
Baseline commit: a9a07c6 |
Josmithr
reviewed
Sep 27, 2024
Josmithr
reviewed
Sep 27, 2024
Josmithr
reviewed
Sep 27, 2024
Josmithr
reviewed
Sep 27, 2024
Josmithr
reviewed
Sep 27, 2024
Josmithr
reviewed
Sep 27, 2024
Josmithr
approved these changes
Sep 28, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
changeset-present
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, unhydrated nodes can be edited but they do not emit any change events. This PR fixes that by properly emitting events. Changes include:
anchor
parameter from the relevant events onAnchorEvents
. This allows those events to be implemented by things that don't have anchors (likeUnhydratedFlexTreeNode
) and things that only sometimes have anchors (likeTreeNodeKernel
). Nobody uses that parameter currently anyway because it is redundant (it's the same as the object that the event is being registered on).UnhydratedFlexTreeNode
when one of its fields is edited. This is listened to by theTreeNodeKernel
, which can then emit its own corresponding event.TreeNodeKernel
. This makes it more obvious what the state transition is, and makes the type checking and safety more explicit.lazy
function helper to better encapsulate the lazy-getting of the events in TreeNodeKernel.