[SWIG] Prevent irrecoverable crash when allocating arrays

[AlbertoEAF]

Our Java SWIG wrappers can lead to an irrecoverable crash of the main process when allocating arrays in SWIG. This was reported in SWIG but unfortunately there was no feedback: swig/swig#1755.

Since this PR (#2859) copies that code quasi-verbatim, from carrays.i, I'll wait for it to be approved to submit changes.

There are 2 ways to fix this:

• Easier) Use operator new (nothrow) -> return null pointer if memory allocation fails

• Harder) Use more SWIG code to wrap the std::bad_alloc exception. -> throw OutOfMemory exception

[guolinke]

@AlbertoEAF sorry for the late response.

Is this issue solved? what is your current plan to fix this?

[AlbertoEAF]

Hello Guolinke, It could be fixed by wrapping with an exception in C++ & SWIG or returning a void pointer which can be wrapped to return an OutOfMemory exception in Java. Although this can be fixed at any time as it does not change the API, this is far from my priority list so maybe we can close it if you want? Thank you

…

On Thu, 6 Aug 2020, 01:07 Guolin Ke, ***@***.***> wrote: @AlbertoEAF <https://github.com/AlbertoEAF> sorry for the late response. Is this issue solved? what is your current plan to fix this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2943 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6K4MOKCZDUQMSN46KL3W3R7HX4PANCNFSM4LTS7K6A> .

[guolinke]

@AlbertoEAF don't hurry, you can fix it anytime.